pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26190 )
Change subject: rework the counters and stats so they work with the threaded mgw ...................................................................... Patch Set 10: (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/26190/10/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26190/10/src/libosmo-mgcp/mgcp_protocol.c@322 PS10, Line 322: LOGP(DLMGCP, LOGL_ERROR, "msg too short: %zd\n", rc); > isn't it initialized by ssize_t rc, msglen = w->x. […] No, in order to be initialized it should be: ssize_t rc, msglen; rc = msglen = w->x.msglen; In any case, I don't see why did that change, using mslen there seems fine? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 Gerrit-Change-Number: 26190 Gerrit-PatchSet: 10 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: dexter <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Thu, 18 Nov 2021 17:11:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: dexter <[email protected]> Gerrit-MessageType: comment
