Patch Set 3: I've updated comments and commit message. My confusion comes from following: currently we check for glibc version and syscall availability at compile time - and use either of those if available. The GnuTLS fallback is added in the same way: if compile-time check for getrandom (both as glibc function and as syscall) fails, only than we compile in GnuTLS. There's no run-time checks.
Is this approach wrong? Shall we do run-time checks instead? Not sure yet how this can be done. -- To view, visit https://gerrit.osmocom.org/4593 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic77866ce65acf524b768882c751a4f9c0635740b Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-HasComments: No
