Patch Set 8: Code-Review+2 (1 comment)
I'm happy to merge it, but my original review comments about using a static variable to cache whether the syscall works has not been implemented. Please follow up with that in a later patch (or create a ticket as a reminder for this optimization) https://gerrit.osmocom.org/#/c/4593/8/src/gsm/gsm_utils.c File src/gsm/gsm_utils.c: Line 437: #endif whitespace -- To view, visit https://gerrit.osmocom.org/4593 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic77866ce65acf524b768882c751a4f9c0635740b Gerrit-PatchSet: 8 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-HasComments: Yes
