Attention is currently required from: laforge, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/20622 )
Change subject: ttcn3-bts-test: use osmo-config-merge to generate config files ...................................................................... Patch Set 9: Code-Review-1 (3 comments) Patchset: PS9: LGTM once the cp commands and FORCE_FETCH is fixed. I highly suggest running it locally, that's how I found that the config files are not copied properly. File ttcn3-bts-test/Makefile: https://gerrit.osmocom.org/c/docker-playground/+/20622/comment/1c68eedb_4c0c1494 PS9, Line 24: FORCE_FETCH: FORCE_FETCH is not needed, cfg above is already a phony target. https://www.gnu.org/software/make/manual/make.html#Phony-Targets > If you write a rule whose recipe will not create the target file, the recipe > will be executed every time the target comes up for remaking. Here is an > example: File ttcn3-bts-test/jenkins.sh: https://gerrit.osmocom.org/c/docker-playground/+/20622/comment/ca596a9d_6f3299c4 PS6, Line 139: cp osmo-bsc-generic.gen.cfg $VOL_BASE_DIR/bsc/ > Wait, actually no. […] Ah right, I did not not see that... but still, it needs to be cp osmo-bsc-generic.gen.cfg $VOL_BASE_DIR/bsc/osmo-bsc.gen.cfg then. Otherwise the file is named osmo-bsc-generic.gen.cfg in the target dir. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/20622 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If15461240f3037c142c176fc7da745a1701ae3f8 Gerrit-Change-Number: 20622 Gerrit-PatchSet: 9 Gerrit-Owner: laforge <[email protected]> Gerrit-Assignee: fixeria <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Thu, 10 Feb 2022 09:28:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
