Attention is currently required from: osmith, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/20622 )
Change subject: ttcn3-bts-test: use osmo-config-merge to generate config files ...................................................................... Patch Set 9: (2 comments) File ttcn3-bts-test/Makefile: https://gerrit.osmocom.org/c/docker-playground/+/20622/comment/b204a4d6_efbac222 PS9, Line 24: FORCE_FETCH: > FORCE_FETCH is not needed, cfg above is already a phony target. […] If I remove FORCE_FETCH, make says: make: Nothing to be done for 'cfg'. even if I change original files in the image. So we better keep it. File ttcn3-bts-test/jenkins.sh: https://gerrit.osmocom.org/c/docker-playground/+/20622/comment/8e9ac5aa_cf3741f2 PS6, Line 139: cp osmo-bsc-generic.gen.cfg $VOL_BASE_DIR/bsc/ > Ah right, I did not not see that... but still, it needs to be […] I see the problem now. It did not affect my tests because the next patch fixes it (renames 'osmo-bsc-generic.gen.cfg' to 'generic/osmo-bsc.gen.cfg'). Let's just rebase this patch on top of I1bc5c51306525c6829e9d8e2991555a99c9b49a2. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/20622 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If15461240f3037c142c176fc7da745a1701ae3f8 Gerrit-Change-Number: 20622 Gerrit-PatchSet: 9 Gerrit-Owner: laforge <[email protected]> Gerrit-Assignee: fixeria <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Thu, 10 Feb 2022 12:25:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
