Attention is currently required from: laforge.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/27132 )

Change subject: utils.py: type annotations for DataObject related methods
......................................................................


Patch Set 2: Code-Review+1

(3 comments)

File pySim/utils.py:

https://gerrit.osmocom.org/c/pysim/+/27132/comment/e7a96607_60e117bb
PS1, Line 1173: desc:str = None, tag:int = None
Optional[str], Optional[int] respectively.


https://gerrit.osmocom.org/c/pysim/+/27132/comment/f1622905_d34979ec 
PS1, Line 1292: str
Optional[str]


https://gerrit.osmocom.org/c/pysim/+/27132/comment/2e054aa3_b0a7a05f
PS1, Line 1403: str
Optional[str]



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/27132
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I291a429e9fe9f1a3fd95dcba3020b0e982154c97
Gerrit-Change-Number: 27132
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Thu, 10 Feb 2022 16:39:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to