Attention is currently required from: fixeria.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/27132 )

Change subject: utils.py: type annotations for DataObject related methods
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

File pySim/utils.py:

https://gerrit.osmocom.org/c/pysim/+/27132/comment/738c8c3d_3454501c
PS1, Line 1173: desc:str = None, tag:int = None
> Optional[str], Optional[int] respectively.
I'm addressing those in a later commit as I've meanwhile re-formatted the 
entire code base.



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/27132
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I291a429e9fe9f1a3fd95dcba3020b0e982154c97
Gerrit-Change-Number: 27132
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Thu, 10 Feb 2022 18:31:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment

Reply via email to