Attention is currently required from: pespin, daniel, dexter. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106 )
Change subject: Add hnbgw tests ...................................................................... Patch Set 5: Code-Review+1 (5 comments) File hnbgw/HNBGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/a2380a80_40655830 PS5, Line 144: mgw_rtp_ip := "1.1.1.1", could use a private ip range https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/a363ba27_9ca74e7c PS5, Line 150: mgw_rtp_ip := "2.2.2.2", could use a private ip range https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/3d0a1d5e_f144639c PS5, Line 156: hnb_rtp_ip := "1.1.1.2", could use a private ip range https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/23a8b76d_bddd2835 PS5, Line 158: cn_rtp_ip := "2.2.2.1", could use a private ip range https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/627a1afb_0582b0ee PS5, Line 622: f_sleep(10.0); 10 seconds are quite long. why do we need a sleep here? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0a2fb795aec83337eda8d9972e6ff264ead61076 Gerrit-Change-Number: 27106 Gerrit-PatchSet: 5 Gerrit-Owner: daniel <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Wed, 16 Feb 2022 10:22:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
