Attention is currently required from: pespin, lynxis lazus, dexter.
daniel has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106 )

Change subject: Add hnbgw tests
......................................................................


Patch Set 6:

(5 comments)

File hnbgw/HNBGW_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/9d73d26d_246ed45b
PS5, Line 144:          mgw_rtp_ip := "1.1.1.1",
> could use a private ip range
Done


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/67b3ebe3_a643edce
PS5, Line 150:          mgw_rtp_ip := "2.2.2.2",
> could use a private ip range
Done


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/18f51ef2_e75d7372
PS5, Line 156:  hnb_rtp_ip := "1.1.1.2",
> could use a private ip range
Done


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/af843581_24d6b175
PS5, Line 158:  cn_rtp_ip := "2.2.2.1",
> could use a private ip range
Done


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/40d97afb_63f36c85
PS5, Line 622:  f_sleep(10.0);
> 10 seconds are quite long. […]
I added a timer to f_hnbap_register and removed the sleep completely



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0a2fb795aec83337eda8d9972e6ff264ead61076
Gerrit-Change-Number: 27106
Gerrit-PatchSet: 6
Gerrit-Owner: daniel <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Wed, 16 Feb 2022 13:11:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: lynxis lazus <[email protected]>
Gerrit-MessageType: comment

Reply via email to