Patch Set 2: Code-Review-1 (1 comment)
https://gerrit.osmocom.org/#/c/4674/2/example/defaults.conf File example/defaults.conf: Line 52: - nominal_power: 23 > Does this mean all octphy BTSs will have two TRXs configured, always? I mea It indeed means all octphy BTS will have two TRX configured always. > IOW, is it possible to add this second trx in the general bsc defaults > instead, without making all BTSs everywhere have two TRXs in their configs? It's not possible as per current implementation, because in conf_for_bsc we simply pass the overlay of all the trx_list configs, which means if one overlay level has 2 trx in the list, the final list will end up having 2 trx. It can be solved in 2 different ways: - Adding an extra "num_trx" attribute in config which specifies that only the first N trx from "trx_list" are to be used (and thus written in the config passed to the bsc). - Adding a BTS API set_num_trx() which sets self.num_trx and that is used to inficate that the first N trx from "trx_list" are to be used (and thus written in the config passed to the bsc). Actually, both are compatible. We may also want to add a BTS API to set TRX in "trx_list" from inside tests too. In any case, I'm not merging this patch for now as the octbts we have is failing to configure it. I pushed it as a showcase to continue work for later once we are able to configure the BTS with 2 TRX without failing. -- To view, visit https://gerrit.osmocom.org/4674 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e988cb0d891c3a8da1b29a3889b5bc8edbbe1ee Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
