Patch Set 2: -Code-Review (1 comment)
https://gerrit.osmocom.org/#/c/4674/2/example/defaults.conf File example/defaults.conf: Line 52: - nominal_power: 23 > It indeed means all octphy BTS will have two TRX configured always. Another idea is to keep an entirely separate defaults set for two trx: bsc_bts_2trx ... but that would probably imply duplicating lots of things. So I guess best is to have some special magic specifically for the number of trx, like the num_trx attribute you mention. Another spin: have a single trx in the defaults (bsc_bts above) and if num_trx is 2, duplicate the first TRX's defaults. Anyway, it would be nice to not need separate defaults for osmo_bts_octphy just because it may use two TRX. -- To view, visit https://gerrit.osmocom.org/4674 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e988cb0d891c3a8da1b29a3889b5bc8edbbe1ee Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
