Attention is currently required from: laforge.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/27357 )
Change subject: bitvec2freq_list(): determine empty set by checking the ARFCN
count
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> IMHO, this is what holger would have called "sideways development". […]
I find it cleaner to relay on the counter ('arfcns' in this case) to check if
the set is empty, rather than checking one of the resulting values ('max').
There is no advantage of this method, it just makes the code easier to read.
But in general, I don't care. This patch can be abandoned.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27357
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I29ca51461beec053bcb8b8210f0ad24bb8c7765f
Gerrit-Change-Number: 27357
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Wed, 02 Mar 2022 09:27:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Gerrit-MessageType: comment
