Attention is currently required from: fixeria.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/27357 )
Change subject: bitvec2freq_list(): determine empty set by checking the ARFCN
count
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS1:
> I find it cleaner to relay on the counter ('arfcns' in this case) to check if
> the set is empty, rath […]
both methods work. but I think for something like this you need to put this
explanation in the commit log. Or maybe mark it as cosmetic if it's no logical
change.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27357
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I29ca51461beec053bcb8b8210f0ad24bb8c7765f
Gerrit-Change-Number: 27357
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Thu, 03 Mar 2022 09:42:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment
