Attention is currently required from: dexter.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/27606 )

Change subject: mgcp_network: do not try to convert RTCP packets
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

File src/libosmo-mgcp/mgcp_network.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/27606/comment/71248817_37cc5b67
PS1, Line 1514:         rc = rx_rtp(msg, proto);
proto is already available in mc (which is contained in msg). No need to pass 
it as param.


https://gerrit.osmocom.org/c/osmo-mgw/+/27606/comment/57f82291_2a7a4a86
PS1, Line 1537:         if (proto == MGCP_PROTO_RTP && 
amr_oa_bwe_convert_indicated(conn_src->end.codec)) {
mc = OSMO_RTP_MSG_CTX(msg);
mc->proto == GCP_PROTO_RTP



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27606
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ic850344d8b5f7710d12e4553a4033b733dced52b
Gerrit-Change-Number: 27606
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Wed, 30 Mar 2022 14:23:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to