Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27606 )
Change subject: mgcp_network: do not try to convert RTCP packets ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/27606/comment/71268422_50d81f4b PS2, Line 1521: static int rx_rtp(struct msgb *msg) It would be great if you can submit a new commit adding a comment here on top explaining that this function is actually handling both RTP and RTCP. Otherwise by just looking at the name it looks as if it only handled RTP. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27606 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic850344d8b5f7710d12e4553a4033b733dced52b Gerrit-Change-Number: 27606 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Wed, 30 Mar 2022 14:44:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
