Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28244 )
Change subject: add pfcp_endpoint ...................................................................... Patch Set 4: (2 comments) File include/osmocom/pfcp/pfcp_endpoint.h: https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/b6d5e571_7b47d9c4 PS3, Line 77: osmo_pfcp_endpoint_cb set_msg_ctx; > General comment: Pointing to historical mistakes is never a good reason not > to improve new code. […] the difficulty is to distinguish between historical mistakes and established conventions, there is no clear discussion and agreement on these things AFAICT... https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/c1ad6694_34bc9d42 PS3, Line 104: > We used a lot of public structs in the beginning, and my experience is that > this _usually_ haunts us […] i'll see if i can apply the extra mile without too much effort. (this will have to happen in libosmo-pfcp.git now, where this patch accidentally already slipped into the master branch during migration) -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28244 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic8d42e201b63064a71b40ca45a5a40e29941e8ac Gerrit-Change-Number: 28244 Gerrit-PatchSet: 4 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Sun, 19 Jun 2022 12:23:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <[email protected]> Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
