Attention is currently required from: neels, fixeria, msuraev.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 )

Change subject: SIGTRAN: add function to check connection existence
......................................................................


Patch Set 9: Code-Review-1

(1 comment)

Patchset:

PS9:
this doesn't just add a function, but it also adds additional debug output on 
the message size.

I'm fine with the function and adding log output in error situations. But I 
don't like the additonal debug logging, see my comment to the other patch.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01
Gerrit-Change-Number: 29087
Gerrit-PatchSet: 9
Gerrit-Owner: msuraev <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: msuraev <[email protected]>
Gerrit-Comment-Date: Wed, 17 Aug 2022 05:41:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to