Attention is currently required from: neels, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 )
Change subject: SIGTRAN: add function to check connection existence ...................................................................... Patch Set 12: (2 comments) File examples/sccp_test_vty.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29087/comment/f7271048_33e03579 PS8, Line 44: int conn_id = atoi(argv[0]), ret; > I agree with Neels that doing "int a = ..., rc;" hides definition of rc. […] Done File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29087/comment/d432aad6_5e08f6f2 PS12, Line 459: osmo_sccp_conn_id_exists > So this function basically converts the result of conn_find_by_id() to > boolean. […] I'm sorry but I've completely lost track of your though in here. We need boolean value but instead of writing function which gives it we should expose another function which doesn't because new symbol? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01 Gerrit-Change-Number: 29087 Gerrit-PatchSet: 12 Gerrit-Owner: msuraev <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 22 Aug 2022 12:00:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: msuraev <[email protected]> Gerrit-MessageType: comment
