Attention is currently required from: neels, pespin.
msuraev has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/28892 )

Change subject: BSSMAP: add assert to reset resending
......................................................................


Patch Set 2:

(2 comments)

Patchset:

PS2:
Without coredump or config I don't think we could reproduce this. I'm fine with 
Harald's suggestion of just adding OSMO_ASSERT() in here.


File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/28892/comment/b446ca3c_e9a1f67e
PS2, Line 3393:         if (!msc->a.bssmap_reset) {
> did you actually face a situation like this?

No, as explained in the ticket.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28892
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I235bdd42ea82e7b5a1a40f437ca34c49ad239c48
Gerrit-Change-Number: 28892
Gerrit-PatchSet: 2
Gerrit-Owner: msuraev <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Wed, 17 Aug 2022 16:14:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <[email protected]>
Gerrit-MessageType: comment

Reply via email to