Attention is currently required from: neels, pespin, msuraev. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28892 )
Change subject: BSSMAP: add assert to reset resending ...................................................................... Patch Set 3: (1 comment) File src/osmo-bsc/bssmap_reset.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28892/comment/23834c9a_1fdb0bae PS2, Line 249: LOGP(DMSC, LOGL_ERROR, "Attempt to reset non-existent BSSMAP\n"); > No caller should call this function with a NULL argument. […] The thing also is, even if someone calls it with a NULL pointer it immediately crashes anyway. I think asserts are helpful when the null pointer is not causing an immediate crash (e.g. stored in some priv struct and then the crash happens way later) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28892 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I235bdd42ea82e7b5a1a40f437ca34c49ad239c48 Gerrit-Change-Number: 28892 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: dexter <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: msuraev <[email protected]> Gerrit-Comment-Date: Thu, 18 Aug 2022 08:18:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <[email protected]> Gerrit-MessageType: comment
