Attention is currently required from: msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29178 )
Change subject: Properly handle send() return code ...................................................................... Patch Set 1: (1 comment) File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/29178/comment/3b570886_6ea18f44 PS1, Line 1334: LOGP(DLINP, LOGL_ERROR, "error to send: %s\n", (ret == -1) ? strerror(errno) : strerror(-ret)); this is not entirely correct, and confusing. What if -ENOTSUP is -1 in some implementation? You should set "ret = -1; errno = ENOTSUP;" in the default switch branch, and use strerror(errno) there. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29178 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: If9b80e855b740254d5414ea50b4ce594855da8e9 Gerrit-Change-Number: 29178 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: msuraev <[email protected]> Gerrit-Comment-Date: Tue, 30 Aug 2022 10:46:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
