Attention is currently required from: msuraev.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/29178 )

Change subject: Properly handle send() return code
......................................................................


Patch Set 1:

(1 comment)

File src/stream.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/29178/comment/92a50424_ce11b34c
PS1, Line 1334:                 LOGP(DLINP, LOGL_ERROR, "error to send: %s\n", 
(ret == -1) ? strerror(errno) : strerror(-ret));
> this is not entirely correct, and confusing. What if -ENOTSUP is -1 in some 
> implementation? […]
Ack



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29178
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: If9b80e855b740254d5414ea50b4ce594855da8e9
Gerrit-Change-Number: 29178
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: msuraev <[email protected]>
Gerrit-Comment-Date: Tue, 30 Aug 2022 11:59:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to