Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29256 )
Change subject: osmux: Drop long time deprecated APIs ...................................................................... Patch Set 2: (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmo-netif/+/29256/comment/1acc0f5e_25bb4b63 PS2, Line 10: been > "not been"? […] We'll require a major bump anyway since the whole API will be improved/extended/changed (see for instance the new _alloc() function in follow up commit). The idea of deprecating APIs is not to keep them forever, but to signal users that the API will be removed at some point, and give some rational time to them to do move to the new APIs. 4 years of time given the amount of users of this API looks more than reasonable to me. File src/osmux.c: https://gerrit.osmocom.org/c/libosmo-netif/+/29256/comment/d9df38cb_756f393a PS2, Line 49: #if 0 > this is "deprecated API" ? Yes, it's implementation stuff from APIs being removed. After those are gone, this is not needed and hence it is removed as part of the API implementation. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29256 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Icbdd364a8161a8113dbf1406716946f684d0a853 Gerrit-Change-Number: 29256 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Comment-Date: Thu, 01 Sep 2022 11:52:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <[email protected]> Gerrit-MessageType: comment
