Attention is currently required from: neels, pespin.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/29256 )

Change subject: osmux: Drop long time deprecated APIs
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

Patchset:

PS3:
My general point on old APIs:

The primary point of our API compatibility is to make sure older versions of 
osmo-foo programs can still be built against more recent libosmo-*.

Third-party applications are relevant in general, but not in this specific case 
where OSMUX is so super osmocom specific, that I doubt any exist.

In general I'm against removing compatibility APIs if there's old osmo-foo 
applications that would no longer build.

In this instance, it is again less of a concern, as OSMUX was always optionally 
and has had very few users we know of.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29256
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Icbdd364a8161a8113dbf1406716946f684d0a853
Gerrit-Change-Number: 29256
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: neels <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Mon, 05 Sep 2022 12:58:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to