Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29540 )
Change subject: stream: Set proper msgb length when returning sctp_notification ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Patchset: PS1: this case of sctp_notification is confusing; if it was clear, the ret from sctp_recvmsg() would return the size of the union sctp_notification, and we would always msgb_put() if rc > 0, and not use sizeof(). Do you think that could work / makes sense / have you tried that? 'man sctp_recvmsg' is a very short joke; would be nice to have the relation of ret, flags and sizeof explained by in-code comments, at least what we assume to be true. if there's anything you can improve, that would be welcome. File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/29540/comment/9d76d392_ac28d363 PS1, Line 1563: msgb_put(msg, ret); > This is the generic and regular place where user data content is updated in > the msgb, so it's fine h […] i understand now that this is needed here for the recv() case. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29540 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I95e2457498fd8e0d790d221cb97695ace0dd673e Gerrit-Change-Number: 29540 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Fri, 30 Sep 2022 15:23:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
