Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29540 )
Change subject: stream: Set proper msgb length when returning sctp_notification ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > this case of sctp_notification is confusing; if it was clear, the ret from > sctp_recvmsg() would retu […] No, tha wouldn't make sense. return code is >0 marking the amount of "user data" read from the conn. What we talk here (sctp_notification) is out-of-band data. The caller knowing nothing about that, aka using the API as regular recv() should not interact with that that, that's why -EAGAIN is returned when out-of-band data is received. Willing to change that would break lots of existing code. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29540 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I95e2457498fd8e0d790d221cb97695ace0dd673e Gerrit-Change-Number: 29540 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Comment-Date: Fri, 30 Sep 2022 15:28:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <[email protected]> Gerrit-MessageType: comment
