Attention is currently required from: tnt.
Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29611 )

Change subject: icE1usb fw: Add Notify PPS on Carrier Detect option
......................................................................


Patch Set 2:

(1 comment)

File firmware/ice40-riscv/icE1usb/usb_gps.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-e1-hardware-lint-69):
https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29611/comment/9cb19a65_3364bb2c
PS2, Line 173:          else if (g_usb_gps.pps.set)
else should follow close brace '}'



--
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29611
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: Ie5d163434323a23912228003add9870fafefedf9
Gerrit-Change-Number: 29611
Gerrit-PatchSet: 2
Gerrit-Owner: tnt <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: tnt <[email protected]>
Gerrit-Comment-Date: Tue, 04 Oct 2022 14:16:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to