tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29611 )
Change subject: icE1usb fw: Add Notify PPS on Carrier Detect option ...................................................................... Patch Set 2: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29611/comment/975b57c4_7e1de3da PS2, Line 10: actually support PPS on CD for USB-CDC devices :( > I guess this is due to the fact that one generally assumes USB devices with > no real CPU interrupt (j […] No, because it's supported on FTDI or PL2023 USB->Serial for instance. It's just that no one bother to implement it for USB CDC ACM devices. (And yes, the jitter / precision isn't great, but over long periods it's not all that bad) Patchset: PS2: > well, it is the kernel coding style to have "} else {". […] Yeah I know and in general I agree, but some times depending on surrounding code, it just doesn't "look" nice and makes it harder to read and so I don't adhere strictly. Just my 2ct anyway. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Ie5d163434323a23912228003add9870fafefedf9 Gerrit-Change-Number: 29611 Gerrit-PatchSet: 2 Gerrit-Owner: tnt <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Comment-Date: Tue, 04 Oct 2022 17:23:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: tnt <[email protected]> Gerrit-MessageType: comment
