Attention is currently required from: neels, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28997 )
Change subject: Add osmo_sock_get_name_multiaddr_buf() ...................................................................... Patch Set 13: (5 comments) File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/28997/comment/3086a90e_83e4b237 PS10, Line 266: LOGL_DEBUG > LOGL_ERROR? No, see the adjacent comment. https://gerrit.osmocom.org/c/libosmocore/+/28997/comment/af79bde1_306b1c7e PS10, Line 271: LOGL_DEBUG > LOGL_ERROR? Same as above. https://gerrit.osmocom.org/c/libosmocore/+/28997/comment/b1f6db36_290933c7 PS10, Line 276: LOGL_DEBUG > LOGL_NOTICE? Done https://gerrit.osmocom.org/c/libosmocore/+/28997/comment/79ab3c52_bb311971 PS10, Line 329: assemble > This comment should go below, you're not assembling anything here yet. Done File tests/socket/socket_sctp_test.c: https://gerrit.osmocom.org/c/libosmocore/+/28997/comment/aee1d093_93056d3d PS10, Line 76: OSMO_SOCK_NAME_MAXLEN * OSMO_SOCK_MAX_ADDRS > sizeof(buf) here and below Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If76595ebd1cf26ba904887a36c4cc14a1b5c4521 Gerrit-Change-Number: 28997 Gerrit-PatchSet: 13 Gerrit-Owner: msuraev <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Sat, 08 Oct 2022 16:39:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
