Attention is currently required from: neels, pespin, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28997 )
Change subject: Add osmo_sock_get_name_multiaddr_buf() ...................................................................... Patch Set 14: (1 comment) Patchset: PS14: > I wonder why do we need an extra API for that. […] It's more consistent with existing multiaddr API: we already have separate functions like osmo_sock_init2_multiaddr() instead of trying to bundle everything into osmo_sock_init*(). Also I think proper place for "universal" API is libosmo-netif which will use the added function as a buildiing block. I'll update https://gerrit.osmocom.org/c/libosmo-netif/+/29079 once this one is merged. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If76595ebd1cf26ba904887a36c4cc14a1b5c4521 Gerrit-Change-Number: 28997 Gerrit-PatchSet: 14 Gerrit-Owner: msuraev <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Thu, 13 Oct 2022 17:59:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
