Patch Set 8: (1 comment)
https://gerrit.osmocom.org/#/c/4906/8/src/libosmo-mgcp/mgcp_conn.c File src/libosmo-mgcp/mgcp_conn.c: Line 140: OSMO_ASSERT(id); are we sure about all o those OSMO_ASSERT? Are we sure they are never called from a code path that receives MGCP messages and parses them? Basically it should not be possible to reach any of the OSMO_ASSERT from a hand-crafted invalid MGCP packet received. -- To view, visit https://gerrit.osmocom.org/4906 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0531a1b670d00cec50078423a2868207135b2436 Gerrit-PatchSet: 8 Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-HasComments: Yes
