Patch Set 8: (1 comment)
https://gerrit.osmocom.org/#/c/4906/8/src/libosmo-mgcp/mgcp_conn.c File src/libosmo-mgcp/mgcp_conn.c: Line 140: OSMO_ASSERT(id); > are we sure about all o those OSMO_ASSERT? Are we sure they are never call (and once we made sure they can't be reached, it amounts to code bloat anyway ... I do understand the desire to assert correctness everywhere, I did the same not so long ago.) -- To view, visit https://gerrit.osmocom.org/4906 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0531a1b670d00cec50078423a2868207135b2436 Gerrit-PatchSet: 8 Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-HasComments: Yes
