Patch Set 2: Code-Review-1 (5 comments)
https://gerrit.osmocom.org/#/c/5100/2/src/host/layer23/include/osmocom/bb/mobile/app_mobile.h File src/host/layer23/include/osmocom/bb/mobile/app_mobile.h: Line 20: int mobile_stop(struct osmocom_ms *ms, int force); as n00b I can't understand the difference between mobile_stop() and mobile_exit(), maybe the functions could use an api comment? https://gerrit.osmocom.org/#/c/5100/2/src/host/layer23/src/mobile/app_mobile.c File src/host/layer23/src/mobile/app_mobile.c: Line 253: if (ms->shutdown != MS_SHUTDOWN_COMPL) (log?) Line 262: "use the same layer2-socket.\nPlease shutdown " sure about \n in the middle of a LOGP? Makes sense in VTY output but "corrupts" the log output Line 278: if (rc < 0) (log?) Line 288: return mobile_exit(ms, 0); (log why nothing is done?) -- To view, visit https://gerrit.osmocom.org/5100 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4aa5ff212fa6bead8f620abaecc6a0b51a99fec Gerrit-PatchSet: 2 Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Owner: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-HasComments: Yes
