Patch Set 2: (1 comment)
https://gerrit.osmocom.org/#/c/5100/2/src/host/layer23/src/mobile/app_mobile.c File src/host/layer23/src/mobile/app_mobile.c: Line 262: "use the same layer2-socket.\nPlease shutdown " > sure about \n in the middle of a LOGP? Makes sense in VTY output but "corru the old code used VTY_NEWLINE instead of \n, which isn't any better either. I think OsmocomBB needs a thorough clean up of such invalid use of libosmocore logging, but that shouldn't be mixed with this completely unrelated patch which just moves code around in this case. -- To view, visit https://gerrit.osmocom.org/5100 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4aa5ff212fa6bead8f620abaecc6a0b51a99fec Gerrit-PatchSet: 2 Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Owner: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-HasComments: Yes
