Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30303 )
Change subject: rate_ctr: use multiple timerfd ...................................................................... Patch Set 4: (2 comments) File src/rate_ctr.c: https://gerrit.osmocom.org/c/libosmocore/+/30303/comment/8722d289_d3864f84 PS3, Line 350: llist_for_each_entry(ctrg, &rate_ctr_groups, list) { > you may want to have a generic function passing RATE_CTR_INTV_* param here > instead of repeating the […] Done https://gerrit.osmocom.org/c/libosmocore/+/30303/comment/79c4128d_8116eeed PS3, Line 441: rc = rate_ctr_init_timer(&rate_ctr_timer_sec, &ts_interval_sec, rate_ctr_timer_cb_sec); > I'm not liking this new approach because it could output unconsistent > metrics, for instance if the m […] How would you suggest to influence timer ordering? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30303 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I78da7119bb745c38eed011b3a8452797a1bfe9d4 Gerrit-Change-Number: 30303 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Tue, 29 Nov 2022 16:27:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
