Attention is currently required from: fixeria, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30617 )
Change subject: ipaccess: Add connect timeout in e1inp_line ...................................................................... Patch Set 4: (1 comment) File include/osmocom/abis/e1_input.h: https://gerrit.osmocom.org/c/libosmo-abis/+/30617/comment/8436f61f_8ca62d2b PS3, Line 231: int connect_timeout; /* secs or E1INP_USE_DEFAULT */ no need for it to be an int, it can be an unsigned int (0 means disabled). BTW, this is quite ipaccess specific, so IMHO this should go into struct ipaccess_line (aka line->driver_data) AFAIU this "connect-timeout" has no meaning in E1 lines. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30617 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I7379102d19c172bed2aa00377d92bc885f54b640 Gerrit-Change-Number: 30617 Gerrit-PatchSet: 4 Gerrit-Owner: daniel <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Comment-Date: Thu, 15 Dec 2022 13:28:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
