Attention is currently required from: pespin, fixeria. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30617 )
Change subject: ipaccess: Add connect timeout in e1inp_line ...................................................................... Patch Set 4: (1 comment) File include/osmocom/abis/e1_input.h: https://gerrit.osmocom.org/c/libosmo-abis/+/30617/comment/81924433_814bc2d7 PS3, Line 231: int connect_timeout; /* secs or E1INP_USE_DEFAULT */ > no need for it to be an int, it can be an unsigned int (0 means disabled). […] As far as I can see that doesn't work with the VTY configuration because there's no way to access the driver data? ipaccess_line is allocated by the driver line_update() which in turn already tries to open/connect so it's not something you can just call. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30617 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I7379102d19c172bed2aa00377d92bc885f54b640 Gerrit-Change-Number: 30617 Gerrit-PatchSet: 4 Gerrit-Owner: daniel <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Thu, 15 Dec 2022 13:52:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
