Attention is currently required from: Hoernchen, laforge.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/30633 )

Change subject: logging: add log level cache
......................................................................


Patch Set 9:

(2 comments)

File src/logging.c:

https://gerrit.osmocom.org/c/libosmocore/+/30633/comment/9a7f5493_3264212b
PS6, Line 107:  memset(tmp_level, 100, osmo_log_info->num_cat);
> Done
NOT DONE YET


https://gerrit.osmocom.org/c/libosmocore/+/30633/comment/487fae7c_0b8878ed
PS6, Line 156:  return (level < log_level_lookup_cache[mapped_subsys]) ? false 
: true;
> This is precisely the inverted "when not to log" approach used by the 
> existing check and I am reusin […]
Just a hint, leave it as you wish.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30633
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I35f8dd9127dd6e7feae392094fd6b3ce2d32558d
Gerrit-Change-Number: 30633
Gerrit-PatchSet: 9
Gerrit-Owner: Hoernchen <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: Hoernchen <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Mon, 19 Dec 2022 18:27:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to