Attention is currently required from: laforge, pespin. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30633 )
Change subject: logging: add log level cache ...................................................................... Patch Set 9: (3 comments) File src/logging.c: https://gerrit.osmocom.org/c/libosmocore/+/30633/comment/83388ef2_310c724e PS6, Line 107: memset(tmp_level, 100, osmo_log_info->num_cat); > NOT DONE YET literally done by adding a comment that explains that it is a random big value which is not going to get its own useless define. https://gerrit.osmocom.org/c/libosmocore/+/30633/comment/014d7d68_d71c6978 PS6, Line 134: struct log_category tmp = { 99, 0 }; > NOT DONE YET literally done by adding a comment that explains that it is a random big value which is not going to get its own useless define. https://gerrit.osmocom.org/c/libosmocore/+/30633/comment/58022b3a_f6a98855 PS6, Line 145: log_level_lookup_cache[mapped_subsys] = tmp.enabled ? tmp.loglevel : 99; > NOT DONE YET literally done by adding a comment that explains that it is a random big value which is not going to get its own useless define. What the function does is described by the preceding comment. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30633 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I35f8dd9127dd6e7feae392094fd6b3ce2d32558d Gerrit-Change-Number: 30633 Gerrit-PatchSet: 9 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Mon, 19 Dec 2022 18:59:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
