Attention is currently required from: neels, pespin, lynxis lazus.
dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/29704 )

Change subject: abis_rsl: when doing packet access, log t1,t3,t2 and fn
......................................................................


Patch Set 8:

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-bsc/+/29704/comment/648ede51_43f9d0e3
PS7, Line 9: the
> .
Done


File src/osmo-bsc/abis_rsl.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/29704/comment/e45af90d_0f283be6
PS7, Line 1822:                 LOG_BTS(rqd->bts, DRSL, LOGL_INFO, "CHAN RQD: 
fn(t1=%u,t3=%u,t2=%u) = %u\n", t1, t3, t2, fn);
> re: why not in the order t1, t2, t3? […]
I think I messed up the comment above. The order is T1, T3, T2. That is the 
order of the binary data in that IE and also the order in which wireshark would 
display the parameters.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29704
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I83d20ba9e0ce6488d458ccf4a85c8445c30e3a89
Gerrit-Change-Number: 29704
Gerrit-PatchSet: 8
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-CC: neels <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Wed, 21 Dec 2022 11:58:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <[email protected]>
Gerrit-MessageType: comment

Reply via email to