Patch Set 1: Code-Review+1 (2 comments)
https://gerrit.osmocom.org/#/c/5157/1/include/osmocom/bsc/osmo_bsc_mgcp.h File include/osmocom/bsc/osmo_bsc_mgcp.h: Line 47: mgcp_trans_id_t mgw_pending_trans; (makes me think ... this requires that we only have a single MGCP transaction pending at any given time. At the moment we do, right?) https://gerrit.osmocom.org/#/c/5157/1/src/osmo-bsc/osmo_bsc_mgcp.c File src/osmo-bsc/osmo_bsc_mgcp.c: Line 825: mgcp_client_cancel(mgcp, mgcp_ctx->mgw_pending_trans); Can it happen that no mgw_pending_trans was set? If yes, we might cancel an unrelated transaction. -- To view, visit https://gerrit.osmocom.org/5157 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40794dff7d10e2b6a96863a2da7e9fbd5662a1bf Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
