Patch Set 2: Code-Review-1 (1 comment)
https://gerrit.osmocom.org/#/c/5004/2/src/osmo_gsm_tester/pcu_osmo.py File src/osmo_gsm_tester/pcu_osmo.py: Line 44: event_loop.wait(self, self.bts.ready_for_pcu) > oh, here it is. I'd have expected this in a test script instead. decided that this is worth a -1. We should not make assumptions on the scenario that the test scripts want to test. Maybe we want to provoke such "BTS not available" in some test? -- To view, visit https://gerrit.osmocom.org/5004 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04d8ed5e02b090d07e91669df44ce354bc6ee749 Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
