Patch Set 2: (3 comments)
https://gerrit.osmocom.org/#/c/5004/2/src/osmo_gsm_tester/pcu_osmo.py File src/osmo_gsm_tester/pcu_osmo.py: Line 43: # othwerwise osmo-pcu ends after connecting to socket with "pcu_l1_if.cpp:416 BTS not available" > (typo otherwise) I'll fix it. Line 44: event_loop.wait(self, self.bts.ready_for_pcu) > decided that this is worth a -1. As I said, I don't agree. Once we support doing something useful once we hit the BTS not available, like re-connecting, we can just drop this line and we will from time to time hit it due to race conditions, and if something goes wrong it will fail. So there's no benefit really in having this in each and every test. https://gerrit.osmocom.org/#/c/5004/2/src/osmo_gsm_tester/templates/osmo-pcu.cfg.tmpl File src/osmo_gsm_tester/templates/osmo-pcu.cfg.tmpl: Line 5: logging level all debug > careful with all-debug on lower layers. We might get a mad log flood here. It logs a lot of stuff but I think for now it's fine since I'm adding support for related features and debugging it. We can always drop to a lower lever in the future once we add some missing features (gprs data) and we have them working. -- To view, visit https://gerrit.osmocom.org/5004 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04d8ed5e02b090d07e91669df44ce354bc6ee749 Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
