Patch Set 1: Code-Review-1 (2 comments)
https://gerrit.osmocom.org/#/c/5184/1/src/libmsc/db.c File src/libmsc/db.c: Line 951: dbi_conn_quote_string_copy(conn, msisdn, &q_msisdn); You should check for return value. Line 955: free(q_msisdn); You shouldn't free memory if dbi_conn_quote_string_copy() failed to allocate it (which it might). -- To view, visit https://gerrit.osmocom.org/5184 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I793a3863e6f4ccbabafc7dabaff97a8c79bbd8e0 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-HasComments: Yes
