Patch Set 1: What's the point of introducing the error in new code just because old code have it in some other place as well? And than fixing that in another patch.
I think you should do the right thing in this patch and than fix other places in a separate patch (as time permits). -- To view, visit https://gerrit.osmocom.org/5184 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I793a3863e6f4ccbabafc7dabaff97a8c79bbd8e0 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: No
