Patch Set 1: Code-Review+2 (1 comment)
https://gerrit.osmocom.org/#/c/5183/1/src/libmsc/db.c File src/libmsc/db.c: Line 844: if (*vsub->msisdn == '\0') I would have thought "strlen(vsub->msisdn) == 0" is more readble, but anyway, we an expect people to know how C strings work ;) -- To view, visit https://gerrit.osmocom.org/5183 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d6169d774b2da04b3051957e364fe620feed51e Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-HasComments: Yes
