Attention is currently required from: laforge, pespin, dexter.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/31417 )

Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload
......................................................................


Patch Set 1:

(2 comments)

File src/common/l1sap.c:

https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/6908c412_672a1ed5
PS1, Line 1261: resp_msg->len != GSM_HR_BYTES + 1
makes sense to use OSMO_UNLIKELY here


https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/42016e8c_fd6d0fb8
PS1, Line 1268: resp_msg->len != GSM_HR_BYTES
makes sense to use OSMO_UNLIKELY here



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31417
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I453562da412fde5b928bd2b588129c58ec8e2a7e
Gerrit-Change-Number: 31417
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Mon, 20 Feb 2023 16:35:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to