Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31413 )
Change subject: open5gs-latest: add osmocom user for ttcn3-pgw-test ...................................................................... Patch Set 1: (2 comments) File open5gs-latest/Dockerfile: https://gerrit.osmocom.org/c/docker-playground/+/31413/comment/f1b64eb1_f44d7e0b PS1, Line 34: crate > create Done, see also: https://gerrit.osmocom.org/c/docker-playground/+/31421. https://gerrit.osmocom.org/c/docker-playground/+/31413/comment/cc7e61b5_41da669c PS1, Line 35: ARG username=osmocom > what's the advantage of making this an argument, instead of just hardcoding a > username? I don't know as I simply copied these lines from open5gs-master/Dockerfile :) -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9139fc52fa6973cf495559d3c4202d9f804a2079 Gerrit-Change-Number: 31413 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Comment-Date: Mon, 20 Feb 2023 17:11:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <[email protected]> Gerrit-MessageType: comment
