Patch Set 2: (1 comment)
https://gerrit.osmocom.org/#/c/5214/2/include/osmo-bts/ecu_fr.h File include/osmo-bts/ecu_fr.h: Line 2: I think, this header should satisfy at least the following dependences itself: #include <stdint.h> #include <stdbool.h> Regarding to GSM_FR_BYTES, including 'osmo-bts/gsm_data.h' could cause the cross-header reference there... -- To view, visit https://gerrit.osmocom.org/5214 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae9e69a9578ae305bca42f834694af96a29084e6 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-HasComments: Yes
