Patch Set 4: Hello Vadim,
I have moved at least the bit offsets to libosmocore now. See #5385 for that. I also wanted to move the code for the ecu, but then I realized that in its current form it would not be so helpful. The probelm I see is that since it runs on the BTS it uses the RTP bit ordering, but you probably need the GSM bit ordering. I am not sure how easy it is to fix this, probably we just have to add a GSM version of the bit offset table und have it parameterizable which of the two to use. Probably it makes sense if you just take the patch from osmo-bsc and add a parameter for the table. If that works for you and the original unit-test still passes I could re-test on osmo-bts-trx. best regards. Philipp -- To view, visit https://gerrit.osmocom.org/5214 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae9e69a9578ae305bca42f834694af96a29084e6 Gerrit-PatchSet: 4 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-HasComments: No
